Range selection spanner delete #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon discussing this on IRC, spanners should exhibit the same behavior for copy and delete. Changing the current behavior to copy spanners without an end element looks difficult. In this case, I will change the delete tests to work the same for all spanners - both ends have to be in a selection to remove a spanner. |
Slurs are removed when start or end segment are removed. Other spanners are removed if the start segment is removed.
Added tests for range delete of spanners, and slurs.
lasconic
added a commit
that referenced
this pull request
Jun 30, 2014
…anner-delete Range selection spanner delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes conditions for the removal of spanners along when deleting a range.
Before, if the spanner overlapped with any part of the selection it was removed.
I have added the following conditions:
If the spanner is a slur, a removal of start or end segment also removes the spanner.
If the spanner is not a slur, it is only removed if the start segment is removed.